-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[incubator/gogs] add install lock opportunity #9315
[incubator/gogs] add install lock opportunity #9315
Conversation
Add opportunity to start with install mode Signed-off-by: olivier beyler <olivier.beyler@orange.com>
increase chart version Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Add installLock parameter Signed-off-by: olivier beyler <olivier.beyler@orange.com>
fixup the typo Signed-off-by: olivier beyler <olivier.beyler@orange.com>
@obeyler: GitHub didn't allow me to assign the following users: responsible. Note that only helm members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @obeyler. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@obeyler are you interested in taking over maintainership of this chart? Or do you know someone else who might be interested? |
@prydonius I just want to contribute a little on it. I think I don't know enough gogs product to become the maintainer. |
cc @helm/charts-maintainers what do you think we should do here? How can we accept a change for a chart that is no longer maintained? |
I'm ok with the change as long as tests are passing. I understand it's a little to add to this PR but I think we need them passing if we want to take on contributions. |
cc @responsible @tvon @sonnyvan @kevinschumacher @jpds @gyliu513 @fuhbar @cheyang @AdamDang as other contributors to this chart are any of you interested in being listed as a maintainer? |
@prydonius I've only bumped the versions for gogs so I will pass. Thank you |
I do not actively use this so I am probably not a good candidate to be listed as a maintainer. |
Thanks @prydonius , I also do not contribute to this chart much, so I will pass as well. |
@prydonius @responsible @tvon @sonnyvan @kevinschumacher @jpds @gyliu513 @fuhbar @cheyang @AdamDang |
Add owner file Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
Signed-off-by: olivier beyler <olivier.beyler@orange.com>
@prydonius @responsible @tvon @sonnyvan @kevinschumacher @jpds @gyliu513 @fuhbar @cheyang @AdamDang |
@obeyler thanks a lot! /ok-to-test /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: obeyler, prydonius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update configmap.yaml Add opportunity to start with install mode Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml increase chart version Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml Add installLock parameter Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml fixup the typo Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Create OWNERS Add owner file Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> Signed-off-by: Ben Drucker <bvdrucker@gmail.com>
* Update configmap.yaml Add opportunity to start with install mode Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml increase chart version Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml Add installLock parameter Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml fixup the typo Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Create OWNERS Add owner file Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com>
* Update configmap.yaml Add opportunity to start with install mode Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml increase chart version Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml Add installLock parameter Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml fixup the typo Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Create OWNERS Add owner file Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com>
* Update configmap.yaml Add opportunity to start with install mode Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml increase chart version Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml Add installLock parameter Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml fixup the typo Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Create OWNERS Add owner file Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
* Update configmap.yaml Add opportunity to start with install mode Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml increase chart version Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml Add installLock parameter Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update values.yaml fixup the typo Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Create OWNERS Add owner file Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com> * Update Chart.yaml Signed-off-by: olivier beyler <olivier.beyler@orange.com>
/assign @responsible
/assign @cheyang
What this PR does / why we need it:
This PR propose to allow launch gogs with INSTALL_LOCK=false
The aim of this is to be able install a gogs automatically with self register option disactivated and be able to create an admin user.
If you want that you just have to install helm with install_lock= false, create an user with a curl on /install path, change the configmap to have install_lock = true and recreate the gogs pod to reload the config map
Which issue this PR fixes
fixes : #6942 , #9278
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]